fix(python): correct BarometerData field types to scalars#9801
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
BarometerBase::Output and RpcLibAdaptorsBase::BarometerData expose altitude/pressure/qnh as real_T. Python defaults incorrectly used Quaternionr/Vector3r, which misleads clients and nested decode. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BarometerDataPython defaults with C++BarometerBase::Output/RpcLibAdaptorsBase::BarometerData(altitude/pressure/qnhas real scalars, notQuaternionr/Vector3r).Motivation
Python client
types.pyhistorically declared wrong barometer field shapes. That mismatches the RPC adaptor and confuses typed clients/nestedfrom_msgpackdefaults. C++ SoT:Verification
PYTHONPATH=PythonClient python3 -m unittest tests.test_barometer_data_types -v→ 2 passedutils.pyPRs (fix(python): use np.frombuffer in string_to_*_array helpers #9795/fix(python): harden write_file empty payloads and PFM handles #9796)Notes
Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h