fix(python): restore Vector3r/Quaternionr scalar ops on NumPy 2#9798
Open
Bartok9 wants to merge 1 commit into
Open
fix(python): restore Vector3r/Quaternionr scalar ops on NumPy 2#9798Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
np.sctypes was removed in NumPy 2.0, so mul/div against numpy scalars raised AttributeError. Use isinstance checks for int/float and np.integer/np.floating. Make msgpackrpc import optional so type math unit tests can run without the full RPC stack. Add offline unit tests. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NumPy 2 removed
np.sctypes. AirSim'sVector3r/Quaternionrmul and div helpers still consulted that table, so any scalar math againstnumpyintegers/floats raisedAttributeErrorunder current defaults.This swaps the check for an
isinstance-based_is_real_numberhelper covering Pythonint/floatandnp.integer/np.floating.msgpackrpcimport is optional so the new offline unit tests can run without the full RPC stack.Motivation
Python 3.12+ environments commonly ship NumPy ≥2. Without this, simple client-side geometry helpers break before simGet* is even called.
Verification
python3 PythonClient/airsim/tests/test_types_numpy2_scalars.py -v # 6 tests OKAI-assisted; human-reviewed.