salvage: Unity multi-drone CaptureCameras lookup (credit @shabpompeiano #4815)#9797
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
microsoft#4815) Find CaptureCameras under the current vehicle instead of the first scene object with that tag so simGetImages works for multi-drone Unity setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of @shabpompeiano’s approach in #4815, rebased onto current
mainwith a null-safe helper and clearer multi-vehicle comments.SetUpCamerasusedGameObject.FindGameObjectWithTag("CaptureCameras"), which only returns the first match in the scene. In multi-drone Unity setups, every vehicle therefore registered the same camera set andsimGetImagesonly reflected one drone.This finds the
CaptureCameraschild under the current vehicle by name, matching the original salvage intent.Credit
Original work: @shabpompeiano in #4815
Verification
Vehicle.cs