Skip to content

add serialization error test for production exception handler #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnkurSinhaaa wants to merge 1 commit into
base: main
Choose a base branch
from
+40 −0
Open

add serialization error test for production exception handler #523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions ...core/src/test/java/com/michelin/kstreamplify/error/DlqProductionExceptionHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import org.apache.kafka.clients.consumer.RetriableCommitFailedException;
import org.apache.kafka.clients.producer.ProducerRecord;
import org.apache.kafka.common.KafkaException;
import org.apache.kafka.common.errors.SerializationException;
import org.apache.kafka.common.serialization.Serde;
import org.apache.kafka.streams.errors.ErrorHandlerContext;
import org.apache.kafka.streams.errors.ProductionExceptionHandler;
Expand Down Expand Up @@ -139,4 +140,43 @@ void shouldReturnRetryOnRetriableException() {
assertEquals(ProductionExceptionHandler.Result.RETRY, response.result());
assertTrue(response.deadLetterQueueRecords().isEmpty());
}

@Test
void shouldSendSerializationExceptionToDlq() {
DlqProductionExceptionHandler handler = new DlqProductionExceptionHandler();
KafkaStreamsExecutionContext.setDlqTopicName("DLQ_TOPIC");
handler.configure(Map.of());

when(producerRecord.key()).thenReturn("key".getBytes(StandardCharsets.UTF_8));
when(producerRecord.value()).thenReturn("value".getBytes(StandardCharsets.UTF_8));
when(producerRecord.topic()).thenReturn("topic");
when(errorHandlerContext.taskId()).thenReturn(new TaskId(0, 0));
when(errorHandlerContext.partition()).thenReturn(0);

ProductionExceptionHandler.Response response =
handler.handleError(errorHandlerContext, producerRecord, new SerializationException("Serialization failed"));

assertEquals(ProductionExceptionHandler.Result.RESUME, response.result());
assertEquals(1, response.deadLetterQueueRecords().size());

Serde<KafkaError> serde = SerdesUtils.getValueSerdes();
KafkaError kafkaError = serde.deserializer()
.deserialize(
"DLQ_TOPIC", response.deadLetterQueueRecords().get(0).value());

assertEquals(
"An exception occurred during the stream internal production. Please find more details about the exception in the cause and stack fields.",
kafkaError.getContextMessage());
assertEquals(0, kafkaError.getOffset());
assertEquals(0, kafkaError.getPartition());
assertEquals("topic", kafkaError.getTopic());
assertEquals("test-app", kafkaError.getApplicationId());
assertNull(kafkaError.getProcessorNodeId());
assertEquals("0_0", kafkaError.getTaskId());
assertEquals("Unknown cause", kafkaError.getCause());
assertTrue(kafkaError.getStack().contains("org.apache.kafka.common.errors.SerializationException: Serialization failed"));
assertEquals("value", new String(kafkaError.getByteValue().array(), StandardCharsets.UTF_8));
assertNull(kafkaError.getValue());
assertEquals("key", new String(response.deadLetterQueueRecords().get(0).key(), StandardCharsets.UTF_8));
}
}
Loading