nRF54L15: fix SHT4x sensor libdep (arduino-sht, not Adafruit_SHT4X)#10515
Merged
thebentern merged 3 commits intoMay 21, 2026
Conversation
SHTXXSensor (the SHT4x driver) includes <SHTSensor.h>, gated by __has_include(<SHTSensor.h>). That header ships in Sensirion/arduino-sht. Adafruit_SHT4X ships Adafruit_SHT4X.h and has no consumer anywhere in src/, so the SHT40 driver was silently excluded from the build -- the nRF54L15 variant could not read an SHT4x sensor as committed in meshtastic#10193. Replace the dead Adafruit_SHT4X libdep with arduino-sht v1.2.6. Validated on nRF54L15-DK: SHT40-AD1B @0x44, 24.3h soak, 0 reboots, temperature/humidity telemetry stable end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
needs-review
Contributor
Author
|
The
The PR now carries the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The nRF54L15-DK variant (added in #10193) lists
Adafruit_SHT4Xinlib_deps, but the SHT4x driverSHTXXSensorincludes<SHTSensor.h>and is gated behind__has_include(<SHTSensor.h>).<SHTSensor.h>is shipped by Sensirion/arduino-sht.Adafruit_SHT4XshipsAdafruit_SHT4X.hinstead and has no consumer anywhere insrc/, so the__has_includegate evaluates false and the SHT4x driver is silently excluded from the build — the variant cannot read an SHT4x sensor.Fix
Replace the dead
Adafruit_SHT4Xlibdep witharduino-sht v1.2.6.Testing
Validated on an nRF54L15-DK with an SHT40-AD1B on TWIM30 (addr
0x44): 24h soak, temperature + humidity telemetry stable end-to-end.🤖 Generated with Claude Code