Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,6 @@ $root: ".widget-datagrid";
z-index: 1;
}

&:focus:not(:focus-visible) {
outline: none;
}

&:focus-visible {
outline: 1px solid var(--brand-primary, $brand-primary);
}
Expand Down Expand Up @@ -285,10 +281,6 @@ $root: ".widget-datagrid";
}
}

& *:focus {
outline: 0;
}

.align-column-left {
justify-content: flex-start;
}
Expand Down Expand Up @@ -576,6 +568,15 @@ $root: ".widget-datagrid";
&:focus-visible {
background-color: var(--brand-primary-50, $color-default-lighter);
}

&:focus-visible {
outline: 1px solid var(--brand-primary, $brand-primary);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Low — Duplicate :focus-visible selector

widget-datagrid-btn-link now has two separate &:focus-visible rules — one for background-color (inside the :hover, :focus-visible block above) and this new standalone one for outline. The duplicate is valid CSS but confusing. They can be merged:

Suggested change
}
&:hover,
&:focus-visible {
background-color: var(--brand-primary-50, $color-default-lighter);
outline: 1px solid var(--brand-primary, $brand-primary);
}

(The :focus-visible block that follows can then be removed.)


&[aria-disabled="true"] {
opacity: 0.5;
cursor: not-allowed;
}
}

:where(#{$root}-selection-counter) {
Expand Down
11 changes: 11 additions & 0 deletions packages/pluggableWidgets/datagrid-web/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Added

- Screen reader announcement region that announces selection count changes when rows are selected or deselected (WCAG 4.1.3).
- Accessible label ("Select all rows") to the select-all checkbox.

### Fixed

- Keyboard focus indicators inside the data grid are no longer hidden by blanket CSS rules.
- Selection clearing no longer causes keyboard focus loss; focus now returns to the select-all checkbox or active grid cell.
- Screen readers no longer announce row selection state twice (as both "selected" and "checked") when using checkboxes.

## [3.11.3] - 2026-07-27

### Added
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading