-
Notifications
You must be signed in to change notification settings - Fork 85
[WC-3084] feat(datagrid-web): add WCAG 4.1.3 status region and selection accessibility improvements #2300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iobuhov
wants to merge
13
commits into
main
Choose a base branch
from
3084/a11y-dg-selection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WC-3084] feat(datagrid-web): add WCAG 4.1.3 status region and selection accessibility improvements #2300
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8ad3cd4
docs(datagrid-web): add OpenSpec artifacts for aria-live footer and c…
iobuhov bd96fe8
feat(datagrid-web): add SelectionStatus component with WCAG 4.1.3 sta…
iobuhov ef05c14
feat(datagrid-web): add focus management, aria-live on button, and E2…
iobuhov 8a6509d
feat(datagrid-web): add focus management, aria-live updates, and sele…
iobuhov 6bebfc3
chore(datagrid-date-filter-web): set MENDIX_VERSION for e2e and e2ede…
iobuhov 2e31c24
feat(datagrid-web): only announce selection changes for bulk operations
iobuhov 05a8ec8
Revert "feat(datagrid-web): only announce selection changes for bulk …
iobuhov 858303e
fix(datagrid-web): drop row aria-selected when checkbox conveys selec…
iobuhov 9eca7a5
test(datagrid-web): assert row selection state via accessibility tree
iobuhov 1279eff
Revert "chore(datagrid-date-filter-web): set MENDIX_VERSION for e2e a…
iobuhov 181f55b
chore: update changelog
iobuhov 0ca9a2d
chore(datagrid-web): set MENDIX_VERSION 10.24.12.86709 for e2e scripts
iobuhov 7ca7c15
test(e2e): update screenshots
iobuhov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+629 Bytes
(100%)
...eb/e2e/DataGrid.spec.js-snapshots/datagrid-virtual-scrolling-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+696 Bytes
(100%)
...idSelection.spec.js-snapshots/datagridMultiSelectionCheckbox-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+691 Bytes
(100%)
...idSelection.spec.js-snapshots/datagridMultiSelectionRowClick-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+711 Bytes
(100%)
...dSelection.spec.js-snapshots/datagridSingleSelectionCheckbox-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+714 Bytes
(100%)
...dSelection.spec.js-snapshots/datagridSingleSelectionRowClick-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:focus-visibleselectorwidget-datagrid-btn-linknow has two separate&:focus-visiblerules — one forbackground-color(inside the:hover, :focus-visibleblock above) and this new standalone one foroutline. The duplicate is valid CSS but confusing. They can be merged:(The
:focus-visibleblock that follows can then be removed.)