Conversation
The page showed a section, a div, dedenting, a demoted heading, a line range and a `.md` file. It did not show a whole-file include, a single line, a promoted heading, a heading pushed past level one, the full `shift-heading-level-by` spelling, a path written inside the included file, a missing target or a URL. Three supporting files join `_examples/`, so no identifier reaches the page twice. The missing-target and URL sections print their call rather than run it, so the site's own build does not fail and does not wait on a network request.
Pandoc raises rather than returning nothing when a fetch fails, so the guard the extension holds for that case is never reached and the render dies. The validation table said the shortcode was removed and the document left intact, which is true of every other failure and false of this one. Also correct the dedent note. The extension still honours yes, no, 1 and 0, and the pinned schema validator now reports every spelling but true and false, so the note saying nothing is reported is no longer right.
My dedent rewrite said every spelling but true and false is reported even though the extension honours it. The extension honours four extra spellings and reads anything else as if the attribute had not been written, which the previous text said and my replacement dropped. The failure sentence covered the two shift rows, where the content is included anyway with no shift or a truncated one, so nothing is removed there. Name the sections that print their call rather than counting from the end, and describe the page's sample files as they are now.
Both run only when their attribute is written, and only the shortcode escaping is unconditional for a markdown file. The sentence read as though all three always happen. Also correct the overlap claim: several examples do pull the same content, and no identifier repeats because extracting a div drops the wrapper that carries it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples page showed a section, a div, a line range, a dedent and a shift. It now covers the rest, filled in place, with three more sample files under
docs/_examples/.The whole file with no fragment, a single line, the canonical
shift-heading-level-byspelling rather than theshiftalias the page always used, a negative shift that promotes headings, a heading pushed past level one, what happens to links inside an included file, a missing target, and a URL. The last two print their calls rather than running them, so the site's own build neither fails nor fetches anything.A heading pushed past level one becomes a bold paragraph and loses its identifier, which the page states and its example relies on.
Two corrections to the reference page came out of the reading, and one is worth attention.
The validation table promised that every failure leaves the surrounding document intact and removes only the shortcode. A target that cannot be read or fetched stops the render instead.
pandoc.mediabag.fetchraises rather than returning nothing, so the extension'sif not fetchedguard and the error message beneath it are never reached. Running the fetch directly under the pandoc Quarto ships confirms it. The fix belongs in the Lua, as apcallaround the fetch, and until then the page says what happens.The dedent note said an unrecognised value is read as if the attribute had not been written, without a warning. The first half is still true and the second is not: the pinned validator coerces only
trueandfalse, so the four other spellings the extension honours are reported, and so is anything it ignores.Verified with a full
quarto render docs, no warnings and no unresolved cross-references,markdownlint-cli2clean, all five reference anchors resolving, and no duplicate identifier on the page. Quoted messages were copied from real failed renders rather than reconstructed.