Skip to content

Modify stops on routes for CR-Newburyport and CR-Franklin #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lemald wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Modify stops on routes for CR-Newburyport and CR-Franklin #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff9d7cd
fix: exclude stops from NS <-> Swampscott local shuttle
lemald Feb 12, 2026
aecc858
fix: Foxboro goes between Windsor Gardens and Walpole
lemald Feb 12, 2026
d8d66b3
fix: include Fairmount stops on Franklin Line
lemald Feb 12, 2026
0a9f214
fix: don't consider Dedham Corp Center to be on Fairmount
lemald Feb 12, 2026
4b8f90c
fix: fix test
lemald Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions apps/state/config/config.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ config :state, :stops_on_route,
"Shuttle-LynnSwampscott-0-" => true,
"Shuttle-NorthStationSwampscott-0-" => true,
"Shuttle-NorthStationSwampscottLimited-0-" => true,
"Shuttle-NorthStationSwampscottLocal-0-" => true,
"Shuttle-NorthStationSwampscottLocal-0-" => false,
"Shuttle-NorthStationSwampscottExpress-0-" => true,
"CR-Newburyport-adde8a7c-" => true,
"CR-Newburyport-76fa2c91-" => true,
Expand Down Expand Up @@ -258,6 +258,9 @@ config :state, :stops_on_route,
"Shuttle-ForgeParkWalpole-0-" => true,
"CR-Franklin-3badde55-" => true,
"CR-Franklin-02118599-" => true,
# Franklin line via Fairmount
"CR-Franklin-807421e2-" => true,
"CR-Franklin-901f1692-" => true,
# Worcester Line shuttles
"Shuttle-AshlandFramingham-0-" => true,
"Shuttle-FraminghamSouthStationExpress-0-" => true,
Expand All @@ -283,10 +286,10 @@ config :state, :stops_on_route,
"place-FB-0109"
],
["place-FB-0148", "place-FB-0166", "place-FB-0177", "place-FB-0191"],
["place-FB-0191", "place-FS-0049", "place-FB-0230"]
["place-FB-0166", "place-FS-0049", "place-FB-0191"]
],
{"CR-Franklin", 1} => [
["place-FB-0230", "place-FS-0049", "place-FB-0191"],
["place-FB-0191", "place-FS-0049", "place-FB-0166"],
[
"place-FB-0109",
"place-DB-0095",
Expand Down Expand Up @@ -531,7 +534,8 @@ config :state, :stops_on_route,
"place-FB-0303",
"place-FB-0275",
"place-FB-0230",
"place-FB-0191"
"place-FB-0191",
"place-FB-0118"
],
{"CR-Fairmount", 1} => [
"place-FB-0166",
Expand All @@ -542,7 +546,8 @@ config :state, :stops_on_route,
"place-FB-0303",
"place-FB-0275",
"place-FB-0230",
"place-FB-0191"
"place-FB-0191",
"place-FB-0118"
],
{"CR-Lowell", 0} => [
"place-WR-0205",
Expand Down
4 changes: 2 additions & 2 deletions apps/state/test/state/stops_on_route_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ defmodule State.StopsOnRouteTest do

test "can drop stops from a route" do
trip_id = "fairmont-trip"
stop_ids = ["place-sstat", "place-FB-0109", "place-FB-0118"]
stop_ids = ["place-sstat", "place-DB-2205", "place-FB-0109"]

State.Stop.new_state(for stop_id <- stop_ids, do: %Model.Stop{id: stop_id})
State.Route.new_state([%Model.Route{id: "CR-Fairmount"}])
Expand All @@ -360,7 +360,7 @@ defmodule State.StopsOnRouteTest do

stop_ids = by_route_id("CR-Fairmount")

assert stop_ids == ["place-sstat", "place-FB-0118"]
assert stop_ids == ["place-sstat", "place-DB-2205"]
end
end

Expand Down