Add windows templates for powershell and batch#232
Open
jonathanmorley wants to merge 1 commit intombland:mainfrom
Open
Add windows templates for powershell and batch#232jonathanmorley wants to merge 1 commit intombland:mainfrom
jonathanmorley wants to merge 1 commit intombland:mainfrom
Conversation
mbland
requested changes
Jun 9, 2018
Owner
mbland
left a comment
There was a problem hiding this comment.
Hey @jonathanmorley, I just resolved some long-standing issues and am getting back to this. This generally looks good, but I'm wondering if there's any way to add any sort of test for these? We can run any such tests as part of our CI by adding them to .appveyor.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contribution under the same terms as this project's license, and
that I have the right to license my contribution under those terms.
cc: @mbland