Conversation
playback_complete was only ever set from inside _audio_callback. When a stream dies abnormally - e.g. a concurrent client invalidating it (PaErrorCode -9988) - the callback stops being invoked, nothing sets the event, and _wait_for_player_with_control() awaits forever. converse() never returns, its finally never runs, and the conch is held indefinitely. finished_callback fires whenever PortAudio tears the stream down for any reason, so the waiter is always released. Tested on 8.12.0 (WSL2/WSLg): normal playback unaffected on both the local CLI and streamable-HTTP paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full analysis, reproduction and evidence in #522.
playback_complete was only ever set from inside _audio_callback. When a stream dies abnormally - e.g. a concurrent client invalidating it (PaErrorCode -9988) - the callback stops being invoked, nothing sets the event, and _wait_for_player_with_control() awaits forever. converse() never returns, its finally never runs, and the conch is held indefinitely.
finished_callback fires whenever PortAudio tears the stream down for any reason, so the waiter is always released.
Tested on 8.12.0 (WSL2/WSLg): normal playback unaffected on both the local CLI and streamable-HTTP paths.