Add changelog entry for #231

[horgh]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @horgh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily updates the project's changelog to reflect a recent fix for Windows build configurations. It addresses an issue where the build process was looking for an outdated library name, ensuring compatibility with newer versions of libmaxminddb by correcting a warning message.

Highlights

• Changelog Update: A new entry for version 1.13.2 has been added to CHANGELOG.md, documenting a fix for Windows build configurations related to the libmaxminddb library.
• Windows Build Configuration Fix: The ext/config.w32 file has been updated to correctly reference maxminddb.lib instead of libmaxminddb.lib in a warning message, aligning with changes in libmaxminddb version 1.6.0 where the lib prefix was removed.

Changelog

• CHANGELOG.md
  • Added a new entry for version 1.13.2 detailing the update to the Windows build configuration to use the correct libmaxminddb name (maxminddb.lib).
• ext/config.w32
  • Modified a warning message to correctly reference maxminddb.lib instead of libmaxminddb.lib when the library is not found during the build process.

Activity

• No human activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the Windows build configuration warning to correctly reflect the library name and adds a corresponding entry to the changelog for version 1.13.2. The changes are correct and improve the accuracy of the build feedback. However, the changelog entry is missing the release date, which is standard for this project. Additionally, please ensure that the version number in ext/php_maxminddb.h is updated to 1.13.2 to match the changelog, as it currently remains at 1.13.1.

[gemini-code-assist]

The changelog entry for version 1.13.2 is missing the release date, which is present in all previous entries. Adding a placeholder or the actual date will maintain consistency and ensure the header length matches the existing 19-dash underline.

Suggested change

	1.13.2
	1.13.2 (YYYY-MM-DD)

[horgh]

Thanks, but we don't see dates until we actually release. This is just adding to the changelog with things that aren't released yet.

[oschwald]

We probably should make this at least a minor version bump given that it would likely require build changes for some consumers.