Repository navigation
Bracket IPv6 literals in the checker's CONNECT line, targets and judges - #305
Merged
Merged
Conversation
maximilianfeix
force-pushed
the
fix/ipv6-authority
branch
from
October 10, 2026 17:22
eb08e11 to
c1440dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Closes #302
netio.authority(host, port)for CONNECT lines (always with the port, IPv6 literals in brackets); the checker's_open_tunneluses it.Target.host_header,Target.label, the URLparse_targetbuilds,Judge.authorityandrunsteps.browser_getgo throughnetio.host_headerinstead of formattinghost:portthemselves.Note: target sites and judges are still resolved with
AF_INET, so an IPv6-only target is turned away before any check (IPv6 was measured and dropped in #1). This only makes the request lines correct wherever a literal does get that far.How was it tested?
python3 -m pytestpasses (1022 passed, 20 skipped on Windows)ruff check .is cleanCONNECT [2606:4700::1]:443with the matchingHostline. Both new tests fail on main.Screenshots
n/a