test(remove): pin the ownership gate's refusal of an emptied worktree directory - #3815
Merged
Conversation
worktrunk-bot
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal's ownership gate (
ensure_holds_this_worktree, #3808) reads<dir>/.gitand stops there, so a directory that has lost that entry holds no worktree of ours and is refused. Nothing named that:wt removereaches the same refusal upstream at theprunablecheck, and the gate's own tests cover the sibling-worktree and foreign-repo cases instead.The case bites where the emptied directory sits inside a repository — a worktree nested in another, or any worktree under a git-managed
~.git rev-parse --git-dirwalks up from it and answers with the enclosing repository's git dir, which is the common dir, so a gate resolving that way reads the directory as the main worktree and accepts it:So the test nests, and asserts that premise before asserting the refusal — otherwise it would go vacuous if the nesting stopped producing that resolution. In the flat sibling layout the walk-up finds no repository at all and resolution simply fails, which is why a sibling-shaped test would pin nothing.
Confirmed discriminating: with resolution swapped back to the
GIT_DIRS-cachedgit_dir(), it fails whileensure_holds_this_worktree_accepts_both_worktree_shapesstill passes.