Remove unnecessary nlohmann_json target to avoid namespace conflicts - #14
Merged
Conversation
Collaborator
|
Thanks. I've passed on to @bkueng as he more or less owns this. Beat, is there anyone else you'd want reviewing changes here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Compiling mavsdk with
-DBUILD_SHARED_LIBS=OFFoption and fetchingnlohmann_jsonin the main project causes a cmake target name conflict error.The actual config is creating a target in the global namespace but is not exposing the library to the consumer.
Fix
Replaced the target with
installsince it was used only to install a header file.