Enable flake8 #528

Activity

1. molinav

   self-assigned this

   on Dec 29, 2021
2. molinav commented on Dec 29, 2021

   

   molinav

   on Dec 29, 2021

   MemberAuthor

   More actions

   Ideally we should run flake8 also in the examples. I remember that once I tried to run all of them and some were triggering errors (I cannot remember more details).
3. WeatherGod commented on Dec 29, 2021

   

   WeatherGod

   on Dec 29, 2021 via email

   Member

   More actions

   I considered this about 5 years ago. Unfortunately, the codebase is very much not PEP8-compliant (I wouldn't be surprised if most of it predates a lot of PEP8). At the time, my goal was to shut down this project, so I didn't see any value in cleaning up the codebase. But, since your goals are different from mine, it might make sense to do some cleanup. I should note that the test suite is extremely sparse, and so I would stay away from auto-formatting tools like `black` that could make inadvertent, subtle changes that aren't covered by unit tests. If anything, I'd suggest starting with converting the manually-run tests and turning them into automated image tests.

   …

   On Wed, Dec 29, 2021 at 9:55 AM Víctor Molina García < ***@***.***> wrote: Ideally we should run flake8 *also* in the examples. I remember that once I tried to run all of them and some were triggering errors (I cannot remember more details). — Reply to this email directly, view it on GitHub <#528 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACHF6BP7DSRSM4IH6LB5W3UTMONJANCNFSM5K6C27EA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
4. molinav

   added this to the v1.4.0 milestone on Aug 23, 2023
5. molinav

   modified the milestones: v1.4.0, v1.5.0 on Jan 9, 2024
6. Cdiaz1234

   added a commit that references this issue on May 4, 2025

   Clean up solar.py to pass flake8 (Issue matplotlib#528)

   baa3eec