Bump to 1.24.6: Modified marks survive closing one of two tabs - #32
Merged
Merged
Conversation
A JSON dictionary open in two tabs (or split) lost every Modified mark in the surviving tab when the other closed, because the per-URI baseline was torn down per panel. Fixed in #31.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump for #31, plus its CHANGELOG entry.
A JSON dictionary open in two tabs (or split) lost every Modified mark in the surviving tab
when the other closed: the "Modified" baseline is keyed by URI — i.e. per document — but was
torn down from the per-panel
onDidDispose. Same for the cross-document-move source deleter.Tag
v1.24.6follows this merge, which builds the.vsixonto a GitHub Release.