Toobig test fix - #138
Merged
Merged
Conversation
The test relied on the ~37 GiB read exceeding MATLAB's array size limit, which only holds on machines with less RAM than that. Lower the limit setting for the duration of the test instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 8 8
Lines 263 263
=======================================
Hits 261 261
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
krisfed
approved these changes
Jul 20, 2026
|
|
||
| methods (Hidden) | ||
| % "Private" constructor - should not be used directly. | ||
| methods (Access = private) |
Member
There was a problem hiding this comment.
I vaguely remember there being some issue with making this constructor private, but can't find anything about it now. So if everything seems to work with this change, should be all good!
Member
Author
There was a problem hiding this comment.
Tests pass, and I couldn't find any usages of this constructor outside of the class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.