Skip to content

Use the npm package for the BZVisualizer.js#12

Open
dou-du wants to merge 4 commits intomaterialscloud-org:developfrom
dou-du:develop
Open

Use the npm package for the BZVisualizer.js#12
dou-du wants to merge 4 commits intomaterialscloud-org:developfrom
dou-du:develop

Conversation

@dou-du
Copy link

@dou-du dou-du commented May 10, 2021

We are going to use the npm package "brillouinzone-visualizer" for the BZVisualizer.js file.

@dou-du dou-du requested a review from giovannipizzi May 10, 2021 19:04
@giovannipizzi
Copy link
Contributor

  1. Can you also please remove all existing references in the repo to the BZ visualiser, so we are sure we're using the one from NPM and not static versions found here?
  2. Can you pin the version of the npm package to a specific version that you tested?
  3. Did you try to create the container and check that all works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants