Support for custom file systems and remote files#24
Open
MasterCarl wants to merge 36 commits intomarmelroy:masterfrom
Open
Support for custom file systems and remote files#24MasterCarl wants to merge 36 commits intomarmelroy:masterfrom
MasterCarl wants to merge 36 commits intomarmelroy:masterfrom
Conversation
Change FBFile to use separate properties for file tree and data URLs
MasterCarl
force-pushed
the
fileDownloads
branch
from
24b975e to
31c1a91
Compare
Owner
|
Hi @MasterCarl, Thanks for working on this. I like the concept and am intrigued by your approach. Please let me know when you consider it "done" so I can properly review it. I had a quick look at the code and I'm not so sure about adding a third-party dependency like Alamofire. If you are only using it for the LoadingViewController please consider replacing with NSURLSession. |
I don't think that this is a relevant option
Author
|
@marmelroy I'm done for now. Feel free to review! |
|
@marmelroy You may consider using my library to implement remote file access, including iCloud Drive, WebDAV, Dropbox and OneDrive. |
MasterCarl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adapted FileBrowser for another project I'm working on, which displays a file system loaded from a JSON REST API. This is a work in progress since I still want to refactor some of my code, fix bugs and add the possibility of loading folder content asynchronously, but maybe you have some comments already.
Although the high-level usage of FileBrowser didn't change, I made some extensive changes to the underlying code. If you think this changes too much, I'd be happy to maintain it as a fork.