Open
Conversation
…d tests, all passing.
…n and written test
nhuntwalker
reviewed
Dec 18, 2017
| for i in range(len(list) - 1): | ||
| if list[i] > list[i + 1]: | ||
| holder = list[i] | ||
| list[i], list[i + 1] = list[i + 1], holder |
There was a problem hiding this comment.
If you're going to just do multiple assignment anyway, why have an intermediate variable?
list[i], list[i + 1] = list[i + 1], list[i]| pip install -e .[testing][development] | ||
| ``` | ||
|
|
||
| ### Linkded List Class Usage |
|
|
||
| ``` | ||
|
|
||
| ### Binaary Heap (min-heap) Class Usage |
| To use insert_sort, from insert_sort import insert_sort. | ||
| Pass in a list of numbers insert_sort(list). | ||
|
|
||
| * _bubble_sort(list) (O(n^2))_ |
There was a problem hiding this comment.
You should probably change this to reflect that you're using Insertion Sort
| return list | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
You're not showing me the best/worst/average cases as was requested by the Spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.