Open
Conversation
…d tests, all passing.
…n and written test
nhuntwalker
reviewed
Dec 15, 2017
| ``` | ||
| Merge sort takes in a list of numbers and uses an merge sort method to return a sorted list. | ||
|
|
||
| To use merge_sort, from merge_sort import merge_sort. |
There was a problem hiding this comment.
Probably put back-ticks around the import statement here to further distinguish the code that someone would write from the text that's explaining what's happening
| """Sort a list using the merge sort method.""" | ||
| if len(list_in) > 1: | ||
| half = len(list_in) // 2 | ||
| list_a = list_in[0:half] |
There was a problem hiding this comment.
You don't need to start this with a 0. If you provide no integer for the first argument of the slice, it'll start at 0 by default
| while l_idx < len(left) and r_idx < len(right): | ||
| if left[l_idx] < right[r_idx]: | ||
| output.append(left[l_idx]) | ||
| l_idx = l_idx + 1 |
There was a problem hiding this comment.
This can be shortened with l_idx += 1
| r_idx = r_idx + 1 | ||
| while l_idx < len(left): | ||
| output.append(left[l_idx]) | ||
| l_idx = l_idx + 1 |
There was a problem hiding this comment.
This and the following statements could be two-line if statements that are less obvious iterative processes:
if l_idx < len(left) - 1:
output.extend(left[l_idx:])
el r_idx < len(right) - 1:
output.extend(right[r_idx:])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.