perf: cover deferred worker promises and native-owned buffers - #1607
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrousavy
force-pushed
the
perf/cleanup-coverage
branch
from
September 7, 2026 10:53
74be7e7 to
9e59043
Compare
mrousavy
marked this pull request as ready for review
September 7, 2026 10:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a native-owned ArrayBuffer bounce at 4 KiB and 1 MiB, plus a deferred Promise roundtrip that is guaranteed pending when returned to JavaScript. JavaScript explicitly triggers worker completion after receiving the Promise; the benchmark name includes that trigger-call cost. The fixture reuses existing worker facilities and keeps one operation in flight. Immediate completion remains covered.
Stacked on #1605. Generated Nitro bindings are checked in. No lifecycle/GC workload or Harness changes are included.
Validation: full Android x86_64 Release app build; actual Swift NitroTest module/header emission, C++ implementation and Swift adapter compilation, Kotlin implementation/generated-spec compilation, TypeScript checks and targeted lint/format checks. A bounded actual iOS Release/Hermes smoke passed C++ and Swift deferred-worker Promise and native-owned buffer bounce cases. Each used distinct calibration/measurement process IDs and completed 20 samples with exactly the calibrated iteration/chunk counts. These establish functional and timing sanity, not CI stability or performance improvements. CI runs are intentionally cancelled immediately after creation to conserve Actions minutes, as requested.