potential bugfix/overscaled 3d tile raycast #13618
Draft
+284
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using terrain with a DEM source that has a lower maxzoom than the current display zoom (e.g., DEM maxzoom of 10 while viewing at zoom 14), the
pointCoordinateraycast was not consistent with the rendered terrain. This caused issues where clicking on the visible terrain surface would return incorrect 3D coordinates.{"type":"raster-dem","tiles":["https://example.tile.server/v1/terrain/{z}/{x}/{y}.png"],"tileSize":256,"maxzoom":10,"encoding":"terrarium"}bug-raycast-on-overscaled-tiles.mov
Solution
The raycast now uses a proxy tile-based approach when overzoomed, which matches the exact geometry rendered by the terrain shader.
fix-raycast-on-proxied-tiles.mov
API Changes
No API Changes
Launch Checklist
Initial Draft
Intent is to show the issue and potential fix for support request 176617. Happy to add some tests, I did some rudimentary benchmark tests but this needs to be done a bit more in depth.