Fix window is not defined issue when doing server side rendering#403
Open
SamSamskies wants to merge 1 commit intomapbox:mainfrom
Open
Fix window is not defined issue when doing server side rendering#403SamSamskies wants to merge 1 commit intomapbox:mainfrom
SamSamskies wants to merge 1 commit intomapbox:mainfrom
Conversation
This fixes the `window is not defined` issue when using `mapbox-gl-geocoder` with an SSR app. PR in the `suggestions` library that fixes the issue tristen/suggestions#42.
|
Any word on this getting merged? Seems silly that this PR has been collecting dust |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
window is not definederror when doing server side rendering. Thesuggestionsdependency is what was causing this issue and this issue has been fixed in v1.7.1. PR that fixed the issue tristen/suggestions#42.