Remove deprecations for upcoming major release#153
Open
Remove deprecations for upcoming major release#153
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated code and legacy compatibility layers in preparation for a major release, as part of broader changes described in mapbender/mapbender#1826. The changes clean up technical debt by eliminating deprecated methods, classes, dead code, and outdated documentation references.
Changes:
- Removed deprecated PHP classes (FeatureTypeService, DataStoreService) and methods (hasId, featureTypeFactory, getFeatureTypeByName, getFeatureTypeDeclarations, getSchemaLayer)
- Removed dead code and legacy compatibility checks (DataTables version check for < 2.0, commented-out resolution filtering code)
- Removed legacy SCSS styles and external documentation references to vis-ui.js
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Mapbender/DigitizerBundle/Resources/public/MbDigitizer.js | Removed commented-out TODO code block and deprecated getSchemaLayer method |
| src/Mapbender/DataSourceBundle/Entity/DataItem.php | Removed deprecated hasId() method |
| src/Mapbender/DataSourceBundle/Component/RepositoryRegistry.php | Removed three deprecated alias methods for DataStore/FeatureType operations |
| src/Mapbender/DataSourceBundle/Component/FeatureTypeService.php | Deleted deprecated service class (full file deletion) |
| src/Mapbender/DataSourceBundle/Component/DataStoreService.php | Deleted deprecated service class (full file deletion) |
| src/Mapbender/DataManagerBundle/Resources/styles/dataManager.element.scss | Removed legacy SCSS styles marked for removal in Mapbender 5 |
| src/Mapbender/DataManagerBundle/Resources/public/TableRenderer.js | Removed DataTables version check for versions < 2.0 |
| src/Mapbender/DataManagerBundle/Resources/public/FormUtil.js | Removed external documentation references to vis-ui.js |
| src/Mapbender/DataManagerBundle/Resources/public/FormRenderer.js | Removed external documentation references to vis-ui.js |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Digitizer does not load with error. |
Member
Author
|
The digitizer develop branch requires DataTables 2 now. Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for full changelog, see PR in mapbender core: mapbender/mapbender#1826