Skip to content

monitor: drop Determinate Nix stringly and HTTP status records silently - #116

Closed
0oAstro wants to merge 1 commit into
manic-systems:mainfrom
0oAstro:determinate-extension-records
Closed

0oAstro wants to merge 1 commit into
manic-systems:mainfrom
0oAstro:determinate-extension-records

Conversation

@0oAstro

@0oAstro 0oAstro commented Nov 18, 2026

Copy link
Copy Markdown

Closes #115.

Determinate Nix extends the internal-JSON protocol with actStringly (start type 10113, string-named activities such as its OpenTelemetry spans) and resHttpStatus (result type 10111, HTTP status and body size). Neither carries anything rom displays, so every build on Determinate Nix printed two ignored unsupported internal-JSON diagnostics.

This drops exactly those two Determinate records without a diagnostic; every other unknown record still reports once as before.

Tested: cargo test -p rom --test protocol_compat (new determinate_extension_records_are_silent uses records captured from Determinate Nix 3.24.2), cargo fmt --check. Also confirmed with nh 4.5.0 patched to this change on Determinate Nix: nh darwin build -- --rebuild no longer prints the diagnostics.

@manic-systems manic-systems locked and limited conversation to collaborators Nov 18, 2026
@faukah faukah closed this Nov 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determinate Nix records 10113 and 10111 produce 'ignored unsupported internal-JSON' diagnostics

2 participants