Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115.
Determinate Nix extends the internal-JSON protocol with
actStringly(start type 10113, string-named activities such as its OpenTelemetry spans) andresHttpStatus(result type 10111, HTTP status and body size). Neither carries anything rom displays, so every build on Determinate Nix printed twoignored unsupported internal-JSONdiagnostics.This drops exactly those two Determinate records without a diagnostic; every other unknown record still reports once as before.
Tested:
cargo test -p rom --test protocol_compat(newdeterminate_extension_records_are_silentuses records captured from Determinate Nix 3.24.2),cargo fmt --check. Also confirmed with nh 4.5.0 patched to this change on Determinate Nix:nh darwin build -- --rebuildno longer prints the diagnostics.