internet-latency-collector: export total packet loss in cloud mode - #4321
Draft
thijsvanemmerik wants to merge 1 commit into
Draft
thijsvanemmerik wants to merge 1 commit into
thijsvanemmerik wants to merge 1 commit into
Conversation
A cloud sample now carries packets sent and packets received, so a pair that is measured and losing every packet reads differently from a pair that is not being measured at all. Without it a dark pair and an unmeasured pair both show up as no rows. The cloud collector fills its location-to-cloud map in its constructor, which already receives every region with its cloud name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of measuring latency between AWS regions with the internet latency collector.
A region pair that loses every packet writes no row, which looks exactly like a pair nobody
measured. This makes the collector write a row with a zero round-trip time when a measurement ran
and nothing came back.
RIPE Atlas reports how many packets each result sent and received. The new code reads those counts,
falling back to counting the individual ping entries, and turns a result with packets sent and none
received into a record at zero round-trip time carrying both counts. A reader can then tell a broken
path from a missing one. The record is skipped when the probe ID or either end's cloud name is
unknown. This runs only when the collector is given a node file of cloud regions to measure, so the
existing path between DoubleZero exchange locations still drops these results.
Merging changes nothing that runs today. That node file is supplied only by a separate deployment,
which does not exist yet.
Test:
go test ./controlplane/internet-latency-collector/internal/ripeatlas/ -run CloudExport