Skip to content

Conversation

@sangeethailango
Copy link
Member

@sangeethailango sangeethailango commented Feb 9, 2026

Description

This PR will remove the estimate point validation

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Bug Fixes
    • Removed the upper limit constraint on estimate point values, enabling users to define higher estimation ranges without the previous maximum restriction.

@makeplane
Copy link

makeplane bot commented Feb 9, 2026

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

The changes update the EstimatePoint model's key field validation by removing the upper bound constraint of 12, keeping only the minimum value constraint of 0. A Django migration is introduced to reflect this database schema change.

Changes

Cohort / File(s) Summary
EstimatePoint Key Field Updates
apps/api/plane/db/migrations/0119_alter_estimatepoint_key.py, apps/api/plane/db/models/estimate.py
Removes MaxValueValidator(12) from the EstimatePoint.key field validators, retaining only MinValueValidator(0). A new migration alters the field to enforce these constraints at the database level.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 No more caps upon the key,
Twelve's the limit used to be,
Now it soars unbounded high,
Watch those estimates reach the sky! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states the intent to change the max value to 50, but the actual changes remove the MaxValueValidator entirely without setting a specific max value. Update the title to accurately reflect that the max validation is being removed entirely, not changed to 50. Example: '[WEB-6149] migration: remove estimate point key max value validation'
Description check ⚠️ Warning The description is incomplete; it lacks details about what validation is being removed, why it's needed, and doesn't fill out other template sections like test scenarios or references. Expand the description to explain the changes in detail, add test scenarios, include the issue reference (WEB-6149), and provide context for why the max value validation is being removed.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch migration-change-estimate-max-value

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sangeethailango sangeethailango added 🔄migrations Contains Migration changes ready to merge labels Feb 9, 2026
@sriramveeraghanta sriramveeraghanta merged commit 57ce2a5 into preview Feb 10, 2026
15 of 16 checks passed
@sriramveeraghanta sriramveeraghanta deleted the migration-change-estimate-max-value branch February 10, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔄migrations Contains Migration changes ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants