Skip to content

Conversation

@nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented May 27, 2020

Description (*)

Fixed Issues (if relevant)

  1. Adapt composite product salability status after reservation was placed. #3054: Adapt composite product salability status after reservation was placed

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

oleksandrkravchuk and others added 30 commits May 8, 2020 17:07
…Salable service.

Add Lightweight implementation.
…Salable service.

Recover cache for storefront areas.
…Salable service.

Remove reservations cache for general scope. Keep cache only for storefront application.
…Salable service.

Revert cache movement to storefront for Stock data.
…Salable service.

Apply code review changes.
…3012.

Refactored consumer. Updating salability status directly instead of inserting on duplicate.
…rver to plugin method to be executed on demand.
…improvements

[Async Salable Status] Moved product salability calculation from observer to plugin method to be executed on demand.
Remove qty check during setQty method. Move Qty check before persist.
@nmalevanec
Copy link
Contributor Author

@magento run all tests.

# Conflicts:
#	InventoryCatalog/Plugin/CatalogInventory/Helper/Stock/AdaptAssignStatusToProductPlugin.php
#	InventoryIndexer/Model/IsProductSalable.php
#	InventoryIndexer/Model/Queue/UpdateIndexSalabilityStatus/IndexProcessor.php
@nmalevanec
Copy link
Contributor Author

@magento run all tests

@nmalevanec
Copy link
Contributor Author

@magento run all tests

1 similar comment
@nmalevanec
Copy link
Contributor Author

@magento run all tests

@nmalevanec
Copy link
Contributor Author

@magento run all tests

@nmalevanec
Copy link
Contributor Author

@magento run all tests

@nmalevanec
Copy link
Contributor Author

@magento run all tests

@nmalevanec
Copy link
Contributor Author

@magento run all tests

@sidolov sidolov changed the base branch from 1.2.0-develop to 1.2-develop November 11, 2020 20:14
@sidolov sidolov changed the base branch from 1.2-develop to develop November 11, 2021 17:50
@engcom-Hotel engcom-Hotel moved this to Ready for Review in Inventory - Pull Request Progress Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

6 participants