Repository navigation
Fixes to calibration script with variable focus - #1253
Merged
Merged
Conversation
The script stores 135 in the calibration output, but actually used 0.
Currently this line used socket name, while calibate:1114 used camera name. With this change, this is consistent and in line with parameter documentation.
mikolajz
changed the title
MaticTonin
approved these changes
Sep 24, 2026
MaticTonin
left a comment
MaticTonin
left a comment
There was a problem hiding this comment.
Overall looks good and correct, there should not be int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix bugs when calibrating variable focus cameras
The bugs are:
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Problems found and reviewed by Claude. Code written manually.
Assisted-by:claude-5-fable
Assisted-by:claude-5.5-opus
Submitted code was reviewed by a human: YES
The author is taking the responsibility for the contribution: YES