Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the test teardown logic by supplying the missing delete_local argument to the delete_dataset call, ensuring datasets are actually removed during cleanup.
- Updated
delete_datasetinvocation intearDownto include thedelete_local=Trueflag.
Comments suppressed due to low confidence (2)
tests/core_tests/unittests/test_converters.py:281
- Add an explicit assertion after calling
delete_dataset(delete_local=True)to verify that the local dataset directory has been removed, so deletion failures are caught in the test.
dataset.delete_dataset(delete_local=True)
tests/core_tests/unittests/test_converters.py:281
- [nitpick] Passing a boolean flag can be unclear; consider splitting into separate methods (e.g.,
delete_local_dataset()anddelete_remote_dataset()) or using an enum/config object to make the deletion intent explicit.
dataset.delete_dataset(delete_local=True)
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Test Results 6 files 6 suites 1h 23m 13s ⏱️ For more details on these failures, see this check. Results for commit 1202ea1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
delete_dataset()method was missing arguments, so nothing was being deleted.Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable