Luxonis-ml v0.6.6 Dataset Deletion Parameters#94
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates dataset deletion parameters in the Luxonis-ML integration by replacing the legacy delete_existing flag with the more explicit delete_local and delete_remote flags.
- Replaces delete_existing with delete_local in multiple dataset constructor calls.
- Ensures both remote and local deletion options are now explicitly defined.
Comments suppressed due to low confidence (3)
datadreamer/utils/luxonis_dataset_converter.py:153
- Verify that the LuxonisDataset constructor has been updated to accept 'delete_local' and 'delete_remote', replacing the legacy 'delete_existing' parameter, so that the dataset deletion behavior remains consistent.
dataset_name, delete_local=True, delete_remote=True
datadreamer/utils/luxonis_dataset_converter.py:168
- Confirm that replacing 'delete_existing' with 'delete_local' in this initializer call aligns with the updated deletion semantics and that any downstream consumers handle this change appropriately.
delete_local=True,
datadreamer/utils/luxonis_dataset_converter.py:173
- Ensure that using only 'delete_local' in the local dataset branch properly reflects the intended behavior for local dataset deletion without relying on the legacy 'delete_existing' flag.
dataset = LuxonisDataset(dataset_name, delete_local=True)
klemen1999
approved these changes
May 8, 2025
Test Results 6 files 6 suites 3h 21m 36s ⏱️ Results for commit 6ad6513. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Luxonis-ml v0.6.6 provides two parameters for dataset deletion:
delete_remotedelete_localThese control which copies of a dataset get removed:
Deletes the remote dataset. Any local copy remains intact.
Deletes the local dataset. The remote dataset remains untouched.
Deletes both the remote and local copies of the dataset.
Note that when you create a remote dataset, a local copy is created as well.
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable