fix: clean up unused variables and duplicate import across 6 modules#545
Open
Kailigithub wants to merge 1 commit into
Open
fix: clean up unused variables and duplicate import across 6 modules#545Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
- fsapp.py: prefix unused event variable with underscore - genericagent_acp_bridge.py: remove unused method assignment - qtapp.py: remove unused exception variable - tui_v3.py: add noqa comment for intentional Keys fallback + remove duplicate dataclass import - tuiapp.py: prefix unused args variable with underscore - helper.py: remove unused errors list initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Clean up ruff F841 (unused variable) and F811 (redefined import) issues across 6 modules:
frontends/fsapp.pyeventassigned but unused_eventfrontends/genericagent_acp_bridge.pymethodassigned but unusedfrontends/qtapp.pyein except clause unusedexcept Exception:frontends/tui_v3.pyKeysfallback + duplicatedataclassimportnoqacomment + remove duplicate importfrontends/tuiapp.pyargsinmain()unused_argsmemory/autonomous_operation_sop/helper.pyerrorslist unusedVerification
ruff check --select F841,F811on all 6 files → All checks passedpython3 -m py_compileon all 6 files → No syntax errors