fix(wechat): check abort flag in streaming loop to honor /stop command#544
Open
Kailigithub wants to merge 1 commit into
Open
fix(wechat): check abort flag in streaming loop to honor /stop command#544Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #396
In WeChat clawbot mode, when a user sends
/stopduring task execution, the_task_abortedflag is set but_handle()never checks it inside its streaming loop. The loop blocks ondq.get(timeout=300)and continues processing accumulated intermediate results, sending them to the user before finally showing[任务已完成].Root Cause
The
while Trueloop in_handle()(line 373) only breaks on'done' in itemorqueue.Emptytimeout. It never checks_task_aborted[uid], so the abort flag is only evaluated after the loop exits — by which time all accumulated results have already been sent.Fix
Added an abort check at the top of each loop iteration:
Also changed
dq.get(timeout=300)to use a try/except forqueue.Emptyso the abort check runs every 300s instead of blocking indefinitely. This ensures the/stopcommand takes effect within one queue poll cycle.Verification
python3 -m py_compile frontends/wechatapp.py— no syntax errorsruff check frontends/wechatapp.py— no new issues introduced