[FPGA] Fix ethernet rejected packet overwriting accepted packet data#533
Merged
raylau1 merged 1 commit intolowRISC:mainfrom May 8, 2026
Merged
Conversation
This improves the Rx first 8 byte patch to use incremented Rx buffer offset for the entire packet if a packet is rejected.
Collaborator
marnovandermaas
left a comment
There was a problem hiding this comment.
Thanks for making this change. Just a small change from my point of view it would be good to assign rx_use_incr_buf_offset for all rx_addr_axis values.
marnovandermaas
approved these changes
May 8, 2026
Collaborator
marnovandermaas
left a comment
There was a problem hiding this comment.
Looks good to me from a code review. Feel free to merge once you're happy with your local testing on FPGA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the Rx first 8 bytes patch to prevent a rejected packet from overwriting data from an accepted packet.
Closes #532
To test that the issue is fixed, run the Ethernet example software, and send packets by running the following in python:
There should not be a received packet with
0xCECECECECECECECEin its data.