[simple_system] UNOPTFLAT Verilator lint waived#2355
Merged
marnovandermaas merged 1 commit intoJun 1, 2026
Conversation
|
I have also encountered the same issue when using the latest stable version of verilator (Verilator 5.044 2026-01-01 rev v5.044-52-g7e7b6d7fb). |
marnovandermaas
force-pushed
the
simple_system_lint
branch
3 times, most recently
from
13e0a0b to
f10b9f8
Compare
Contributor
|
@marnovandermaas: Looks like I should probably have reviewed this a few months ago... (sorry). I see that Satnam's PR doesn't need the Anyway, this looks like an obviously correct change: very happy to review if this is rebased. |
marnovandermaas
force-pushed
the
simple_system_lint
branch
3 times, most recently
from
2af23b0 to
4badfd9
Compare
Contributor
Author
|
@rswarbrick sorry for not getting back to this sooner. You're right that the controller_run one was not necessary. |
These are new warnings that are produced by newer Verilator versions like v5.042.
marnovandermaas
force-pushed
the
simple_system_lint
branch
from
4badfd9 to
1899a63
Compare
rswarbrick
approved these changes
May 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are new warnings that are produced by newer Verilator versions like v5.042.
Closes: #2345