refactor: Collect tps/cgs with tighter types in testplan.py#219
Merged
Conversation
AlexJones0
approved these changes
May 21, 2026
AlexJones0
left a comment
AlexJones0
left a comment
Contributor
There was a problem hiding this comment.
Nice! This looks like a great improvement. Thanks @rswarbrick!
There's no functional change, but this avoids needing to pass around constructors. As a result, the inferred types for Testplan.testpoints and Testpaln.covergroups are tighter, meaning that some following code is now well-typed. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
element-list-types
branch
from
a8684aa to
c2227ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no functional change, but this avoids needing to pass around constructors. As a result, the inferred types for Testplan.testpoints and Testpaln.covergroups are tighter, meaning that some following code is now well-typed.