Skip to content

Improve failure bucket presentation in block reports #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexJones0 merged 3 commits into from
May 5, 2026
Merged

Improve failure bucket presentation in block reports #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3c15ae
feat: sort failure buckets in the HTML block reports
AlexJones0 Apr 29, 2026
b26b37b
refactor: line -> context_line to avoid naming conflict in report
AlexJones0 Apr 29, 2026
0a8fbbc
feat: show the failure bucket size in the block HTML report
AlexJones0 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/dvsim/sim/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,16 @@ def render(
file_name = results.block.variant_name()
log.debug("Generating HTML report for '%s'", file_name)
block_file = f"{file_name}.html"
sorted_buckets = dict(
sorted(results.failed_jobs.buckets.items(), key=lambda kv: len(kv[1]), reverse=True)
)
artifacts[block_file] = render_template(
path="reports/block_report.html",
data={"results": results, "version": summary.version},
data={
"results": results,
"failed_jobs": sorted_buckets,
"version": summary.version,
},
)
if outdir is not None:
(outdir / block_file).write_text(artifacts[block_file])
Expand Down
12 changes: 6 additions & 6 deletions src/dvsim/templates/reports/block_report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
{% set timestamp = results.timestamp %}
{% set stages = results.stages %}
{% set coverage = results.coverage %}
{% set failed_jobs = results.failed_jobs %}
{% block content %}
<div class="container-md">
<div class="row">
Expand Down Expand Up @@ -204,7 +203,7 @@ <h2>Simulation Results: {{ block.variant_name(sep='/') }}</h2>
</div>
{% endif %}

{% if failed_jobs.buckets %}
{% if failed_jobs %}
<div class="row py-3">
<div class="col">
<h3>Error Messages</h3>
Expand All @@ -219,9 +218,10 @@ <h3>Error Messages</h3>
</tr>
</thead>
<tbody>
{% for msg, job_list in failed_jobs.buckets.items() %}
{% for msg, job_list in failed_jobs.items() %}
<tr class="table-primary">
<td colspan=5>{{ msg }}</td>
<td colspan=4>{{ msg }}</td>
<td><b>{{ job_list|length }} test run{{ "s" if job_list|length > 1 else "" }}</b></td>
</tr>
{% for job in job_list %}
<tr>
Expand All @@ -230,8 +230,8 @@ <h3>Error Messages</h3>
<td>{{ job.seed }}</td>
<td>{{ job.line }}</td>
<td>
{% for line in job.log_context %}
<div>{{ line }}</div>
{% for context_line in job.log_context %}
<div>{{ context_line }}</div>
{% endfor %}
</td>
</tr>
Expand Down
Loading