#84: Addition additional states of contenteditable#85
Open
dinukadesilva wants to merge 1 commit intolovasoa:masterfrom
Open
#84: Addition additional states of contenteditable#85dinukadesilva wants to merge 1 commit intolovasoa:masterfrom
dinukadesilva wants to merge 1 commit intolovasoa:masterfrom
Conversation
Owner
|
thank you for the PR |
Owner
|
but I don't think exposing the state as a list of boolean properties is a good idea |
Owner
|
what should the user expect if he sets several boolean state options to true? |
Author
|
It is according to the priority sequence mentioned in https://w3c.github.io/editing/contentEditable.html#h-contenteditable. That's why these have been enclosed in separate if clauses. |
Author
|
@lovasoa Any updates regarding this pull request |
lovasoa
changed the title
|
any updates on this? can i help with any changes to move this along? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #84
https://w3c.github.io/editing/contentEditable.html#h-contenteditable