Skip to content

Keep Editor.js mobile block controls inline - #532

Merged
lopugit merged 4 commits into
mainfrom
codex/editorjs-controls-right
Sep 1, 2026
Merged

Keep Editor.js mobile block controls inline#532
lopugit merged 4 commits into
mainfrom
codex/editorjs-controls-right

Conversation

@lopugit

@lopugit lopugit commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep the Editor.js + and settings controls on the active block line at the mobile inline-end/right edge
  • reserve the control-row width so long and right-aligned text cannot collide with the buttons
  • add the regression checklist, changelog entry, and refreshed Graphify snapshot

Validation

  • npm --prefix remix run test:editorjs — 54/54 passed
  • npm --prefix remix run lint:files -- app/components/Editor/LongTextEditor.tsx — passed
  • npm --prefix remix run build — passed, including Vercel output verification
  • live browser QA at 390px and desktop: first/middle/final blocks align controls at inline end; + menu and settings tune UI open without clipping; zero horizontal overflow; mobile page checked top-to-bottom
  • repository-wide npm --prefix remix run typecheck remains red on unrelated pre-existing main-branch errors; the touched Editor component is absent from the failure list

Manual checklist

  • TESTING.md Editor.js rich-text post/composer checks, including the new inline toolbar-control placement row.

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
thingtime Building Building Preview Sep 1, 2026 4:24am UTC

Request Review

@github-actions github-actions Bot added lopu: mergeable The PR branches can currently be merged without conflicts lopu: overlapping files This PR changes files also changed by another open PR lopu: out-of-date The PR branch is behind its target branch and removed lopu: mergeable The PR branches can currently be merged without conflicts labels Sep 1, 2026
# Conflicts:
#	graphify-out/snapshots/v1/231640accf2ecfa21a2f1275e13e34c49564e1d8b5583c74f89ce2a731363212/ba3515fca56ce99b11acca71390f95b8c81e98c7069320716d5fc34b5837034f/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/231640accf2ecfa21a2f1275e13e34c49564e1d8b5583c74f89ce2a731363212/ba3515fca56ce99b11acca71390f95b8c81e98c7069320716d5fc34b5837034f/cost.json
#	graphify-out/snapshots/v1/231640accf2ecfa21a2f1275e13e34c49564e1d8b5583c74f89ce2a731363212/ba3515fca56ce99b11acca71390f95b8c81e98c7069320716d5fc34b5837034f/graph.json
#	graphify-out/snapshots/v1/231640accf2ecfa21a2f1275e13e34c49564e1d8b5583c74f89ce2a731363212/ba3515fca56ce99b11acca71390f95b8c81e98c7069320716d5fc34b5837034f/manifest.json
#	graphify-out/snapshots/v1/5e929b445f4537db47da10d5013c67c8b0bd2ca26eef9303d103533d4eb3d342/9dfffdbae73e92271088b86e6c4f35b7f3a521a1c23104795ec222407f18c688/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/5e929b445f4537db47da10d5013c67c8b0bd2ca26eef9303d103533d4eb3d342/9dfffdbae73e92271088b86e6c4f35b7f3a521a1c23104795ec222407f18c688/cost.json
#	graphify-out/snapshots/v1/5e929b445f4537db47da10d5013c67c8b0bd2ca26eef9303d103533d4eb3d342/9dfffdbae73e92271088b86e6c4f35b7f3a521a1c23104795ec222407f18c688/graph.json
#	graphify-out/snapshots/v1/5e929b445f4537db47da10d5013c67c8b0bd2ca26eef9303d103533d4eb3d342/9dfffdbae73e92271088b86e6c4f35b7f3a521a1c23104795ec222407f18c688/manifest.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/cost.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/graph.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/manifest.json
@github-actions github-actions Bot added lopu: mergeable The PR branches can currently be merged without conflicts and removed lopu: out-of-date The PR branch is behind its target branch labels Sep 1, 2026
@github-actions github-actions Bot added lopu: conflicting GitHub reports merge conflicts for the current PR snapshot lopu: queued The current PR snapshot is waiting in Lopu's PR-management queue and removed lopu: mergeable The PR branches can currently be merged without conflicts labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🤖 Lopu live PR update

Status: ✅ Lopu finished — this PR is closed or merged

Current phase: The resolver branch work is complete

Estimated completion: Done — no further active-work ETA.

Time conversion (UTC source)

Moment UTC Los Angeles Melbourne
Updated 2026-09-01 04:55 UTC (UTC+00:00) 2026-08-31 21:55 PDT (UTC-07:00) 2026-09-01 14:55 AEST (UTC+10:00)

Los Angeles and Melbourne use their real IANA time zones, so PDT/PST and AEST/AEDT offsets change automatically.

Lopu queue and PR pulse

Scope Metric Count
Repository Open PRs 36
Repository Conflicting 27
Repository Out-of-date with target 0
Repository GitHub state unknown 1
Repository Part of an open stack 0
Repository Touch files changed by another open PR 37
Repository Target a non-root branch without an open parent PR 0
This resolver batch Admitted snapshots 3
This resolver batch Currently resolving 0
This resolver batch Waiting 0
This resolver batch Finished 3

Related PR context

  • Stack: No open parent or child PR currently links to this branch.
  • Target: main is a repository root/integration branch.
  • Changed-file overlap: 3 changed files are also touched by #54, #57, #68, #74, #79, #92, #93, #101, #105, #107, #124, #127, +8 more.

Exact branch pair: maincodex/editorjs-controls-right.

Timeline

  • 04:23 UTC — Detected conflicts between main and codex/editorjs-controls-right; assigning the exact snapshot to the resolver queue.
  • 04:24 UTC — Still safely queued behind earlier admitted Lopu work; no duplicate resolver was spawned.
  • 04:34 UTC — 10-minute check-in: still working — Waiting in Lopu's serialized PR-management lane.
  • 04:45 UTC — 10-minute check-in: still working — Waiting in Lopu's serialized PR-management lane.
  • 04:55 UTC — The resolver worker completed successfully and the PR is no longer open.

Technical run details — optional; this comment is the human-facing source of truth.

@github-actions github-actions Bot removed the lopu: queued The current PR snapshot is waiting in Lopu's PR-management queue label Sep 1, 2026
# Conflicts:
#	graphify-out/snapshots/v1/2f5c41f83eb4f4f3603dc10879b79471921241218fa0b3a5942e2777fdf80e70/ef9e651b613ea1bbb021144e327bfdc634a74eac70bee8f0f20534c80f8ec4a2/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/2f5c41f83eb4f4f3603dc10879b79471921241218fa0b3a5942e2777fdf80e70/ef9e651b613ea1bbb021144e327bfdc634a74eac70bee8f0f20534c80f8ec4a2/cost.json
#	graphify-out/snapshots/v1/2f5c41f83eb4f4f3603dc10879b79471921241218fa0b3a5942e2777fdf80e70/ef9e651b613ea1bbb021144e327bfdc634a74eac70bee8f0f20534c80f8ec4a2/graph.json
#	graphify-out/snapshots/v1/2f5c41f83eb4f4f3603dc10879b79471921241218fa0b3a5942e2777fdf80e70/ef9e651b613ea1bbb021144e327bfdc634a74eac70bee8f0f20534c80f8ec4a2/manifest.json
#	graphify-out/snapshots/v1/302e1ffe3cd45434d7e1bad64fcc9be8d151a919fa6331ee7c785976e9bd2b1a/bc043bdd9e3bdf557016f024e97eea54c6c9ff9093a29acf62d3c4663d4b5452/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/302e1ffe3cd45434d7e1bad64fcc9be8d151a919fa6331ee7c785976e9bd2b1a/bc043bdd9e3bdf557016f024e97eea54c6c9ff9093a29acf62d3c4663d4b5452/cost.json
#	graphify-out/snapshots/v1/302e1ffe3cd45434d7e1bad64fcc9be8d151a919fa6331ee7c785976e9bd2b1a/bc043bdd9e3bdf557016f024e97eea54c6c9ff9093a29acf62d3c4663d4b5452/graph.json
#	graphify-out/snapshots/v1/302e1ffe3cd45434d7e1bad64fcc9be8d151a919fa6331ee7c785976e9bd2b1a/bc043bdd9e3bdf557016f024e97eea54c6c9ff9093a29acf62d3c4663d4b5452/manifest.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/cost.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/graph.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/manifest.json
#	remix/CHANGELOG.md
@github-actions github-actions Bot added lopu: queued The current PR snapshot is waiting in Lopu's PR-management queue lopu: mergeable The PR branches can currently be merged without conflicts and removed lopu: conflicting GitHub reports merge conflicts for the current PR snapshot labels Sep 1, 2026
@lopugit
lopugit merged commit d436d7f into main Sep 1, 2026
76 checks passed
@github-actions github-actions Bot removed lopu: mergeable The PR branches can currently be merged without conflicts lopu: overlapping files This PR changes files also changed by another open PR lopu: queued The current PR snapshot is waiting in Lopu's PR-management queue labels Sep 1, 2026
github-actions Bot added a commit that referenced this pull request Sep 1, 2026
# Conflicts:
#	graphify-out/snapshots/v1/261ef7f9a4a592f5d7015e6b11c7858e100314d148b1fd3bc8eece5353eb6488/034a4d199b44e44ef7aa98b86814f51fc398deafcddfa5f2ca2087aada57e1b3/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/261ef7f9a4a592f5d7015e6b11c7858e100314d148b1fd3bc8eece5353eb6488/034a4d199b44e44ef7aa98b86814f51fc398deafcddfa5f2ca2087aada57e1b3/cost.json
#	graphify-out/snapshots/v1/261ef7f9a4a592f5d7015e6b11c7858e100314d148b1fd3bc8eece5353eb6488/034a4d199b44e44ef7aa98b86814f51fc398deafcddfa5f2ca2087aada57e1b3/graph.json
#	graphify-out/snapshots/v1/261ef7f9a4a592f5d7015e6b11c7858e100314d148b1fd3bc8eece5353eb6488/034a4d199b44e44ef7aa98b86814f51fc398deafcddfa5f2ca2087aada57e1b3/manifest.json
#	graphify-out/snapshots/v1/302e1ffe3cd45434d7e1bad64fcc9be8d151a919fa6331ee7c785976e9bd2b1a/bc043bdd9e3bdf557016f024e97eea54c6c9ff9093a29acf62d3c4663d4b5452/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/302e1ffe3cd45434d7e1bad64fcc9be8d151a919fa6331ee7c785976e9bd2b1a/bc043bdd9e3bdf557016f024e97eea54c6c9ff9093a29acf62d3c4663d4b5452/cost.json
#	graphify-out/snapshots/v1/302e1ffe3cd45434d7e1bad64fcc9be8d151a919fa6331ee7c785976e9bd2b1a/bc043bdd9e3bdf557016f024e97eea54c6c9ff9093a29acf62d3c4663d4b5452/graph.json
#	graphify-out/snapshots/v1/302e1ffe3cd45434d7e1bad64fcc9be8d151a919fa6331ee7c785976e9bd2b1a/bc043bdd9e3bdf557016f024e97eea54c6c9ff9093a29acf62d3c4663d4b5452/manifest.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/GRAPH_REPORT.md
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/cost.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/graph.json
#	graphify-out/snapshots/v1/673aee29a31628108de7087eea3ef997262e25fe672f2714fa71b73cf716a244/5cf8c60b62ce1f413301d64dfac46cfa2d66d43e7e417f012dc1013913cb0332/manifest.json
@lopugit
lopugit deleted the codex/editorjs-controls-right branch September 1, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant