[Lopu] Skip superseded queued snapshots before expensive work - #406
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ai-rebase-pausedrecovery and all exact-lease publication checksWhy
Live activation after #403 proved the durable queue is non-cancelling, but an older PR #288 worker waited for the slot, then spent 8 minutes on full checkout and Graphify before the final lease correctly rejected a moved base. This moves the same safety decision ahead of all expensive work. Existing queued runs remain untouched; new controller runs gain the early gate after this PR merges.
Evidence: https://github.com/lopugit/thingtime/actions/runs/32822938370
Validation
node .github/scripts/resolve-pr-conflicts-routing-contract.mjs --self-testnode .github/scripts/workflow-control-plane-contract.mjs --self-testnode .github/scripts/promotion-worker-routing-contract.mjsgit diff --check