perf(debug): remove render-time and per-keypress console leaks (TODO 14) - #112
Closed
lopugit wants to merge 2 commits into
Closed
perf(debug): remove render-time and per-keypress console leaks (TODO 14)#112lopugit wants to merge 2 commits into
lopugit wants to merge 2 commits into
Conversation
CommanderV2 logged commanderActive on every render and every keycode on every keypress; ThingtimeURL logged location/path/thing objects on every render (retaining thing references in console history). All removed. The useThingtimeScope leak named in TODO 14 was already gone from main. Verified: build:client passes; live worktree dev session shows zero occurrences of the removed patterns across route navigation + typing in the Commander, which still renders suggestions and accepts input. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 21, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TODO 14 — 🧹 Remove render-time debug leaks in the hot path.
CommanderV2.tsx: removed the per-rendercommanderActivelog and the per-keypresscommander key listener e?.codelog.ThingtimeURL.tsx: removed all four per-render logs (location, getting/gotthing, and the unconditional return-value log) — these logged wholethingobjects on every render, retaining references in console history.window.useThingtimeScopeunbounded-array leak named in the TODO was already removed on main (stale line refs) — nothing to do there.Verified:
build:clientpasses; live worktree dev session (port 17590) shows zero occurrences of the removed log patterns across a route navigation plus typing 8 characters into the Commander, which still renders suggestions and accepts input normally; no console errors.Also annotates TODO 14 in
TODO/TODO.md.Session 3 of 10 parallel todo sessions (previous: #94, #102, #105); claim branch pushed before work started.
🤖 Generated with Claude Code