Open
Conversation
achrinza
force-pushed
the
ci/node18-v5.x
branch
2 times, most recently
from
30a3f10 to
71e86b9
Compare
- Test against MongoDB v3.6 and v5.0 - fix Travis CI config - Use `npm ci --ignore-scripts` Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
force-pushed
the
ci/node18-v5.x
branch
2 times, most recently
from
22b1eab to
0659b3e
Compare
Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
force-pushed
the
ci/node18-v5.x
branch
from
0659b3e to
701da2e
Compare
dhmlau
reviewed
Apr 22, 2022
| matrix: | ||
| node-version: [10, 12, 14] | ||
| mongodb-version: [4.4] # the latest stable version | ||
| mongodb-version: [3.6, 4.4, 5.0] |
Member
There was a problem hiding this comment.
according to https://www.mongodb.com/support-policy/lifecycles, mongodb v3.6 has reached EOL last April. Do we still want to include that?
Member
Author
There was a problem hiding this comment.
Since connector 5.x was released when MongoDB 3.x was still supported, I wanted to make sure it still works with that version (i.e. Dropping a MongoDB version should require a semver major on the connector as well).
dhmlau
approved these changes
May 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rifa Achrinza 25147899+achrinza@users.noreply.github.com
Checklist
npm testpasses on your machine