feat: re-export ChatStorage and make storage_config fallible#154
Draft
osmaczko wants to merge 1 commit into
Draft
feat: re-export ChatStorage and make storage_config fallible#154osmaczko wants to merge 1 commit into
osmaczko wants to merge 1 commit into
Conversation
Collaborator
|
FYI: PrivateV1 is End of life, and will be removed from the codebase in favor of DirectV1 once Client is compatible with InboxV2 registrations. |
Callers that build an encrypted store had to depend on `libchat` directly for `ChatStorage`, and `ChatClientBuilder::storage_config` panicked on a bad config, which aborts the process under `panic = "abort"`. - Re-export `ChatStorage` from logos-chat so callers can name the store type without a direct `libchat` dependency. - `storage_config` now returns `Result<_, ChatError>` instead of `.expect()`, so an unopenable database surfaces as an error. Updates the chat-cli callers.
osmaczko
force-pushed
the
fix/privatev1-message-delivery
branch
from
ab51612 to
443a26d
Compare
osmaczko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small ergonomic changes to the
logos-chatclient crate, needed by callers(logos-chat-module) that build an encrypted store and want to talk only to
logos-chatwithout depending onlibchatdirectly.ChatStoragefromlogos-chatso callers can name the store typewithout a direct
libchatdependency.ChatClientBuilder::storage_confignow returnsResult<_, ChatError>insteadof
.expect(), so an unopenable database surfaces as an error rather thanaborting the process under
panic = "abort". Updates the chat-cli callers.(Re-scoped from the earlier PrivateV1 message-delivery change, which is dropped:
logos-chat-module is moving to DirectV1, where senders are MLS-bound and the
PrivateV1 drop does not arise.)