KeyPackage Unification#147
Merged
Merged
Conversation
kaichaosun
approved these changes
Jun 24, 2026
seemenkina
approved these changes
Jun 24, 2026
Remove GroupV2Convo::new_pending Flatten types
jazzz
force-pushed
the
jazzz/keypkg_unification
branch
from
0f9604e to
2b8c231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
De-MLS used to own KeyPackage generation for its own Conversations. This was because the MLS parameters were defined within the library and it needed to be sure that the configuration matched its needs.
With MlsProvider being passed in externally, creating KeyPackages unique to this conversation type creates friction, and duplication which makes debugging more difficult.
Solution
Complete remove the local Keypackage generation and rely on InboxV2 to create and register the required KeyPacakges.
GroupV2Convo::new_pendingandGroupV2Convo::accept_welcomeinto a single constructorGroupV2Convo::new_from_welcome