include authToken on requestModule#86
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK’s capability_module.requestModule invocation so the auth/capability token is included in the method arguments (in addition to being passed as the transport-level authToken), aligning the call shape between the sync wrapper and the async auto-requestModule flow.
Changes:
- Add
authTokenas the first argument tocapability_module.requestModuleinLogosAPIConsumer::requestModule. - Update
LogosAPIClient::invokeRemoteMethodAsync’s chainedrequestModulecall to passcapabilityTokenas the first argument.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cpp/logos_api_consumer.cpp | Adjusts the sync requestModule wrapper to include the token in the argument list. |
| cpp/logos_api_client.cpp | Updates the async chained requestModule call to include the token in the argument list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const QString qAuthToken = QString::fromStdString(authToken); | ||
| QVariant result = plugin->callMethod(qAuthToken, QStringLiteral("requestModule"), | ||
| QVariantList() << qAuthToken << qOrigin << qTarget, 20000); |
| capabilityToken, | ||
| QStringLiteral("capability_module"), | ||
| QStringLiteral("requestModule"), | ||
| QVariantList() << origin << objectName, | ||
| QVariantList() << capabilityToken << origin << objectName, |
| capabilityToken, | ||
| QStringLiteral("capability_module"), | ||
| QStringLiteral("requestModule"), | ||
| QVariantList() << origin << objectName, | ||
| QVariantList() << capabilityToken << origin << objectName, |
📊 cpp-sdk doc-test reportThe real accounts module, run through a logoscore daemon with the whole stack built against this commit of the C++ SDK — rendered alongside the commands actually run and their output (updated each run, commit Pages can take a minute to update after the run finishes. |
No description provided.