Repository navigation
Conversation
Signed-off-by: boulea7 <zln1905391059@163.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OverlayNG can throw
Invalid ordinate index: 2when an overlay result mixesCoordinateXYwith coordinates carrying Z. Copy and normalize coordinates before constructing result rings and lines, including diagnostic edge output, so elevation population can fill missing Z values without modifying input coordinates. Determine spatial dimensions and measures separately to choose the correct coordinate type.Fixes #1238.
Validated on Java 21: all 30
OverlayNGZTestcases and all 2321 core tests pass, along with core Checkstyle and PMD checks. Core production sources also compile withjavac --release 8.