Add generics to geom.util extractors (fixes #1113)
#1170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1113 by adding type parameter declarations to the
geom.utilextractor utilities, reducing rawList/Collectionusage and the need for casts in user code.Changes:
List<Polygon>,List<LineString>,List<Point>)Collection<? super T>overloads so you can collect into eitherCollection<T>orCollection<Geometry>GeometryExtracter(newextractByClass(...)helpers) to avoid duplicationGeometryFilterforGeometry#apply(...)compatibilityCompatibility:
Mostly backwards compatible. Note that due to Java generics, returned values like
List<LineString>cannot be assigned toList<Geometry>:This PR only touches
geom.util. These changes involve more design decisions than straightforward "add generics" fixes (likegetNodedSubstrings), so broader changes are left for a future PR.