Fix typos and improve clarity in README.md and CONTRIBUTING.md#290
Open
A-RAKSHITHA wants to merge 1 commit intollnl:developfrom
Open
Fix typos and improve clarity in README.md and CONTRIBUTING.md#290A-RAKSHITHA wants to merge 1 commit intollnl:developfrom
A-RAKSHITHA wants to merge 1 commit intollnl:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typo in "Contributions" Section:
Old: "We are managing contributions through pull requents here on GitHub."
New: "We are managing contributions through pull requests here on GitHub."
Change: Corrected the typo "requents" to "requests."
Clarity Improvements in the "Contributions" Section:
Old: "please make master the target branch."
New: "please set the target branch to master when creating your pull request."
Change: Made the instruction clearer.
Old: "New features should be created in feature/branches and be based on master."
New: "New features should be developed in feature/ branches, based on the master branch."
Change: Improved the wording for clarity.
Incomplete Sentence Fix:
Old (incomplete): "SAMRAI's tests are all in the /source/test and are spilt up by"
New (completed): "SAMRAI's tests are all in the /source/test directory and are split up by module to match different parts of the codebase. Please review existing tests to determine where your test should go."
Change: Completed the cut-off sentence and corrected the typo "spilt" to "split."