Skip to content

fix: pre-select LPT as bridge destination token#708

Merged
rickstaa merged 1 commit into
mainfrom
fix/bridge-lpt-destination-token
Jun 16, 2026
Merged

fix: pre-select LPT as bridge destination token#708
rickstaa merged 1 commit into
mainfrom
fix/bridge-lpt-destination-token

Conversation

@rickstaa

@rickstaa rickstaa commented Jun 16, 2026

Copy link
Copy Markdown
Member

The "Bridge LPT" menu option (#705) opened the Arbitrum portal with LPT on the source side but ETH on the destination side, because the portal falls back to ETH when destinationToken is absent.

Add destinationToken to BRIDGE_LPT_URL so LPT is pre-selected on both the Ethereum and Arbitrum One sides.

Note: the portal expects the L1 (Ethereum) LPT address for destinationToken and resolves the L2 counterpart internally.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated bridge URL configuration to include additional token routing parameters for improved cross-chain token transfers.

The Arbitrum portal defaults the destination token to ETH unless
destinationToken is passed explicitly. Add it (using the L1 LPT
address, which the portal maps to its L2 counterpart) so the bridge
opens with LPT pre-selected on both sides.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@rickstaa rickstaa requested a review from ECWireless as a code owner June 16, 2026 20:12
Copilot AI review requested due to automatic review settings June 16, 2026 20:12
@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
explorer-arbitrum-one Ready Ready Preview, Comment Jun 16, 2026 8:13pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6d81603f-ac1c-4eac-aa58-e6f7b87504a9

📥 Commits

Reviewing files that changed from the base of the PR and between 98d3092 and 1a0a394.

📒 Files selected for processing (1)
  • constants/links.ts

📝 Walkthrough

Walkthrough

The BRIDGE_LPT_URL constant in constants/links.ts is updated to append a destinationToken=${ETHEREUM_LPT_ADDRESS} query parameter alongside the existing token parameter in the Arbitrum bridge portal URL.

Changes

BRIDGE_LPT_URL query parameter update

Layer / File(s) Summary
Add destinationToken to BRIDGE_LPT_URL
constants/links.ts
BRIDGE_LPT_URL now includes both token and destinationToken query parameters, both set to ETHEREUM_LPT_ADDRESS, in the Arbitrum bridge portal URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

  • livepeer/explorer#705: Adds the "Bridge LPT" UI that consumes the BRIDGE_LPT_URL constant updated in this PR.

Suggested reviewers

  • ECWireless
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete compared to the template. It lacks required sections such as Type of Change, Related Issue(s), Changes Made, Testing, and Impact/Risk assessment. Add the missing sections: specify 'fix' as the Type of Change, reference related issue #705, list the changes made, document testing approach, and assess risk level and user impact.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding the destinationToken parameter to pre-select LPT on both sides of the bridge.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bridge-lpt-destination-token

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the “Bridge LPT” deep link so the Arbitrum bridge UI pre-selects LPT on both the source (Ethereum) and destination (Arbitrum One) sides by explicitly providing destinationToken.

Changes:

  • Update BRIDGE_LPT_URL to include destinationToken (using the L1 LPT address) so the destination token no longer falls back to ETH.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rickstaa rickstaa merged commit 2c37a7e into main Jun 16, 2026
9 of 10 checks passed
@rickstaa rickstaa deleted the fix/bridge-lpt-destination-token branch June 16, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants